netdev - Re: [PATCH net-next] net: bridge: pop vlan from skb if filtering is disabled but it's a pvid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200921221214.skhtyevm6pdbaee7@skbuf>
Date:   Tue, 22 Sep 2020 01:12:14 +0300
From:   Vladimir Oltean <olteanv@...il.com>
To:     Florian Fainelli <f.fainelli@...il.com>
Cc:     Nikolay Aleksandrov <nikolay@...dia.com>,
        "stephen@...workplumber.org" <stephen@...workplumber.org>,
        Roopa Prabhu <roopa@...dia.com>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "andrew@...n.ch" <andrew@...n.ch>
Subject: Re: [PATCH net-next] net: bridge: pop vlan from skb if filtering is
 disabled but it's a pvid

On Mon, Sep 21, 2020 at 10:56:07PM +0300, Vladimir Oltean wrote:
> On Mon, Sep 21, 2020 at 12:44:43PM -0700, Florian Fainelli wrote:
> > Vladimir, let me know if you have a patch for DSA and I can give it a
> > try quickly. Thanks!
> 
> Let me clean it up a little and send it, I need to export a wrapper over
> br_get_pvid() for external use, called under rcu_read_lock().

Here it is as an attached patch, sorry that it can't be simpler than
that. Please call the function from where you need it, and then submit
it yourself to net-next.

Also, you'll notice a lockdep warning when you test it. That's what the
br_vlan_get_pvid_rcu() fix I've just sent is for. Make sure you also
take that.

Thanks,
-Vladimir

View attachment "0001-net-dsa-untag-the-bridge-pvid-from-rx-skbs.patch" of type "text/x-diff" (5998 bytes)