netdev - Re: [PATCH net-next] ipvs: Remove unused macros

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 21 Sep 2020 09:24:40 +0200
From:   Simon Horman <horms@...ge.net.au>
To:     YueHaibing <yuehaibing@...wei.com>
Cc:     wensong@...ux-vs.org, ja@....bg, pablo@...filter.org,
        kadlec@...filter.org, fw@...len.de, davem@...emloft.net,
        kuba@...nel.org, netdev@...r.kernel.org, lvs-devel@...r.kernel.org,
        netfilter-devel@...r.kernel.org, coreteam@...filter.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] ipvs: Remove unused macros

On Fri, Sep 18, 2020 at 09:16:56PM +0800, YueHaibing wrote:
> They are not used since commit e4ff67513096 ("ipvs: add
> sync_maxlen parameter for the sync daemon")
> 
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>

Thanks, this look good to me.

Acked-by: Simon Horman <horms@...ge.net.au>

Pablo, please consider this for nf-next.

> ---
>  net/netfilter/ipvs/ip_vs_sync.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/net/netfilter/ipvs/ip_vs_sync.c b/net/netfilter/ipvs/ip_vs_sync.c
> index 2b8abbfe018c..16b48064f715 100644
> --- a/net/netfilter/ipvs/ip_vs_sync.c
> +++ b/net/netfilter/ipvs/ip_vs_sync.c
> @@ -242,9 +242,6 @@ struct ip_vs_sync_thread_data {
>        |                    IPVS Sync Connection (1)                   |
>  */
>  
> -#define SYNC_MESG_HEADER_LEN	4
> -#define MAX_CONNS_PER_SYNCBUFF	255 /* nr_conns in ip_vs_sync_mesg is 8 bit */
> -
>  /* Version 0 header */
>  struct ip_vs_sync_mesg_v0 {
>  	__u8                    nr_conns;
> -- 
> 2.17.1
>