netdev - Question on commit: [PATCH] net: stmmac: Delete txtimer in suspend()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <c1275e42-7df9-ddce-33ac-589f813e73f9@st.com>
Date:   Mon, 21 Sep 2020 11:35:24 +0200
From:   Christophe ROULLIER <christophe.roullier@...com>
To:     <netdev@...r.kernel.org>
Subject: Question on commit: [PATCH] net: stmmac: Delete txtimer in suspend()


Hi all,

I would like to know if you have already seen this behavior :

Without this patch 
https://patchwork.ozlabs.org/project/netdev/patch/20200201020124.5989-1-nicoleotsuka@gmail.com/, 
during suspend/resume sequence on STM32MP15 (stmmac driver):

[   69.184175] dwc2 49000000.usb-otg: suspending usb gadget configfs-gadget

[   69.358831] stm32-dwmac 5800a000.ethernet eth0: Link is Down

[   69.370345] Disabling non-boot CPUs ...

[   69.371309] CPU1 killed.

[   69.379201] Enabling non-boot CPUs ...

[   69.382421] CPU1 is up

[   69.402201] dwmac4: Master AXI performs any burst length

[   69.402235] stm32-dwmac 5800a000.ethernet eth0: No Safety Features 
support found

[   69.402306] stm32-dwmac 5800a000.ethernet eth0: configuring for 
phy/rgmii-id link mode

[   69.405656] usb usb2: root hub lost power or was reset

[   69.805154] usb 2-1: reset high-speed USB device number 2 using 
ehci-platform

[   69.883813] dwc2 49000000.usb-otg: resuming usb gadget configfs-gadget

[   70.189888] OOM killer enabled.

[   70.192983] Restarting tasks ... done.

[   70.215832] PM: suspend exit

root@...32mp1-disco:~# [   75.608337] stm32-dwmac 5800a000.ethernet 
eth0: Link is Up - 1Gbps/Full - flow control rx/tx

And the same soft + patch “net: stmmac: Delete txtimer in suspend()" :

[  181.931229] dwc2 49000000.usb-otg: suspending usb gadget configfs-gadget

[  182.110153] stm32-dwmac 5800a000.ethernet eth0: Link is Down

[  182.112333] stm32-dwmac 5800a000.ethernet eth0: Link is Up - 
1Gbps/Full - flow control rx/tx

[  182.112420] stm32-dwmac 5800a000.ethernet eth0: Link is Down

[  182.120247] Disabling non-boot CPUs ...

[  182.121186] CPU1 killed.

[  182.129095] Enabling non-boot CPUs ...

[  182.132309] CPU1 is up

[  182.151590] dwmac4: Master AXI performs any burst length

[  182.151626] stm32-dwmac 5800a000.ethernet eth0: No Safety Features 
support found

[  182.151695] stm32-dwmac 5800a000.ethernet eth0: configuring for 
phy/rgmii-id link mode

[  182.154930] usb usb2: root hub lost power or was reset

[  182.555119] usb 2-1: reset high-speed USB device number 2 using 
ehci-platform

[  182.633763] dwc2 49000000.usb-otg: resuming usb gadget configfs-gadget

[  182.953899] OOM killer enabled.

[  182.957008] Restarting tasks ... done.

[  182.996662] PM: suspend exit

root@...32mp1-disco:~# [  188.408297] stm32-dwmac 5800a000.ethernet 
eth0: Link is Up - 1Gbps/Full - flow control rx/tx

I would like to understand why there is more :

[  182.110153] stm32-dwmac 5800a000.ethernet eth0: Link is Down

[  182.112333] stm32-dwmac 5800a000.ethernet eth0: Link is Up - 
1Gbps/Full - flow control rx/tx

[  182.112420] stm32-dwmac 5800a000.ethernet eth0: Link is Down

Any idea ?

Regards.

Christophe.