netdev - Re: [PATCH v3 bpf-next 04/11] bpf: Change bpf_sk_storage_*() to accept ARG_PTR_TO_BTF_ID_SOCK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 22 Sep 2020 10:17:20 +0100
From:   Lorenz Bauer <lmb@...udflare.com>
To:     Martin KaFai Lau <kafai@...com>
Cc:     bpf <bpf@...r.kernel.org>, Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Kernel Team <kernel-team@...com>,
        Networking <netdev@...r.kernel.org>
Subject: Re: [PATCH v3 bpf-next 04/11] bpf: Change bpf_sk_storage_*() to
 accept ARG_PTR_TO_BTF_ID_SOCK_COMMON

On Tue, 22 Sep 2020 at 08:04, Martin KaFai Lau <kafai@...com> wrote:
>
> This patch changes the bpf_sk_storage_*() to take
> ARG_PTR_TO_BTF_ID_SOCK_COMMON such that they will work with the pointer
> returned by the bpf_skc_to_*() helpers also.
>
> A micro benchmark has been done on a "cgroup_skb/egress" bpf program
> which does a bpf_sk_storage_get().  It was driven by netperf doing
> a 4096 connected UDP_STREAM test with 64bytes packet.
> The stats from "kernel.bpf_stats_enabled" shows no meaningful difference.
>
> The sk_storage_get_btf_proto, sk_storage_delete_btf_proto,
> btf_sk_storage_get_proto, and btf_sk_storage_delete_proto are
> no longer needed, so they are removed.
>
> Signed-off-by: Martin KaFai Lau <kafai@...com>

I like that we can get rid of the init code.

Acked-by: Lorenz Bauer <lmb@...udflare.com>

--
Lorenz Bauer  |  Systems Engineer
6th Floor, County Hall/The Riverside Building, SE1 7PB, UK

www.cloudflare.com