netdev - Re: [PATCH -next] net/mlx5: simplify the return expression of mlx5_ec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d6a509a9340c3840f4cfc9db2883e02bb7a60e9f.camel@kernel.org>
Date:   Tue, 22 Sep 2020 12:53:01 -0700
From:   Saeed Mahameed <saeed@...nel.org>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     Qinglang Miao <miaoqinglang@...wei.com>,
        Leon Romanovsky <leon@...nel.org>,
        "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] net/mlx5: simplify the return expression of
 mlx5_ec_init()

On Tue, 2020-09-22 at 08:04 -0700, Jakub Kicinski wrote:
> On Mon, 21 Sep 2020 22:52:30 -0700 Saeed Mahameed wrote:
> > On Mon, 2020-09-21 at 21:10 +0800, Qinglang Miao wrote:
> > > Simplify the return expression.
> > > 
> > > Signed-off-by: Qinglang Miao <miaoqinglang@...wei.com>
> > > ---
> > >  drivers/net/ethernet/mellanox/mlx5/core/ecpf.c | 6 +-----
> > >  1 file changed, 1 insertion(+), 5 deletions(-)
> > > 
> > >   
> > 
> > Applied to net-next-mlx5.
> 
> Beware:
> 
> drivers/net/ethernet/mellanox/mlx5/core/ecpf.c: In function
> ‘mlx5_ec_init’:
> drivers/net/ethernet/mellanox/mlx5/core/ecpf.c:46:6: warning: unused
> variable ‘err’ [-Wunused-variable]
>   46 |  int err = 0;
>      |      ^~~

Thanks Jakub

Yes, Saw this in my CI as well, 
will resolve this one myself.
and for next time I will wait for the CI result before replying ;)