lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Tue, 22 Sep 2020 22:05:24 +0200
From:   Pavel Machek <pavel@....cz>
To:     Saeed Mahameed <saeed@...nel.org>
Cc:     eranbe@...lanox.com, lariel@...lanox.com, saeedm@...lanox.com,
        leon@...nel.org, davem@...emloft.net, kuba@...nel.org,
        netdev@...r.kernel.org, linux-rdma@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net/mlx5: remove unreachable return

On Tue 2020-09-22 12:54:20, Saeed Mahameed wrote:
> On Mon, 2020-09-21 at 22:54 -0700, Saeed Mahameed wrote:
> > On Mon, 2020-09-21 at 13:41 +0200, Pavel Machek wrote:
> > > The last return statement is unreachable code. I'm not sure if it
> > > will
> > > provoke any warnings, but it looks ugly.
> > >     
> > > Signed-off-by: Pavel Machek (CIP) <pavel@...x.de>
> > > 
> > > 
> > 
> > Applied to net-next-mlx5.
> > 
> > Thanks,
> > Saeed.
> > 
> 
> Actually checkpatch reports this issue:
> WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal
> patch author 'Pavel Machek <pavel@....cz>'
> 
> Do you want me to override the Signed-off-by tag with the above email ?

Sorry about that.

Actually, overriding patch author to match signoff would be better (I
should have sent it from: denx), but either way is okay with me.

Best regards,
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Download attachment "signature.asc" of type "application/pgp-signature" (196 bytes)

Powered by blists - more mailing lists