netdev - Re: [PATCH] net: lantiq: Add locking for TX DMA channel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1506e7f9-2438-0a72-fb3c-fc40543fedf2@hauke-m.de>
Date:   Tue, 22 Sep 2020 23:40:50 +0200
From:   Hauke Mehrtens <hauke@...ke-m.de>
To:     David Miller <davem@...emloft.net>
Cc:     kuba@...nel.org, netdev@...r.kernel.org,
        martin.blumenstingl@...glemail.com
Subject: Re: [PATCH] net: lantiq: Add locking for TX DMA channel

On 9/22/20 2:18 AM, David Miller wrote:
> From: Hauke Mehrtens <hauke@...ke-m.de>
> Date: Tue, 22 Sep 2020 00:31:13 +0200
> 
>> The TX DMA channel data is accessed by the xrx200_start_xmit() and the
>> xrx200_tx_housekeeping() function from different threads. Make sure the
>> accesses are synchronized by using locking around the accesses.
>>
>> Signed-off-by: Hauke Mehrtens <hauke@...ke-m.de>
> 
> The TX lock will be held during the xrx200_start_xmit() routine, always.
> 
> Please use that in xrx200_tx_housekeeping() instead of adding a new
> unnecessary lock.
> 
> Thank you.
> 

Thank you for the information, I was not aware of this locking, I will
send a new version of this patch using the normal TX lock.

Hauke



Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)