netdev - Re: [net-next v2 PATCH 1/2] octeontx2-af: Introduce tracepoints for mailbox

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CALHRZup3CU1O-pDTFO=jkXkHUC8191ovqYmJanhd0_na7ccRYw@mail.gmail.com>
Date:   Tue, 22 Sep 2020 08:23:47 +0530
From:   sundeep subbaraya <sundeep.lkml@...il.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
        Sunil Kovvuri Goutham <sgoutham@...vell.com>,
        Subbaraya Sundeep <sbhatta@...vell.com>,
        Jiri Pirko <jiri@...nulli.us>
Subject: Re: [net-next v2 PATCH 1/2] octeontx2-af: Introduce tracepoints for mailbox

Hi Jakub,

On Tue, Sep 22, 2020 at 4:48 AM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Mon, 21 Sep 2020 22:32:41 +0530 sundeep.lkml@...il.com wrote:
> > diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu_trace.c b/drivers/net/ethernet/marvell/octeontx2/af/rvu_trace.c
> > new file mode 100644
> > index 0000000..f0b3f17
> > --- /dev/null
> > +++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu_trace.c
> > @@ -0,0 +1,14 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +/* Marvell OcteonTx2 RVU Admin Function driver tracepoints
> > + *
> > + * Copyright (C) 2020 Marvell International Ltd.
> > + */
> > +
> > +#define CREATE_TRACE_POINTS
> > +#include "rvu_trace.h"
> > +
> > +EXPORT_TRACEPOINT_SYMBOL(otx2_msg_alloc);
> > +EXPORT_TRACEPOINT_SYMBOL(otx2_msg_send);
> > +EXPORT_TRACEPOINT_SYMBOL(otx2_msg_check);
>
> I don't think you need to export send and check.
>
> They are only used in the mbox module where they are defined.
>
Agreed. I will remove those and send the next spin.

> Otherwise looks acceptable to me.
>
Thanks

> Please make sure you CC everyone who gave you feedback.
Sure.

Sundeep