netdev - Re: [PATCH ethtool] bnxt: Add Broadcom driver support.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAACQVJr7=C3h0YeU5wo5mbU3PnOs6z_7SMkxmCMhVFxd0ydQDw@mail.gmail.com>
Date:   Tue, 22 Sep 2020 11:32:12 +0530
From:   Vasundhara Volam <vasundhara-v.volam@...adcom.com>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     Michal Kubecek <mkubecek@...e.cz>,
        David Miller <davem@...emloft.net>,
        Netdev <netdev@...r.kernel.org>,
        Jakub Kicinski <kuba@...nel.org>,
        Michael Chan <michael.chan@...adcom.com>,
        Edwin Peer <edwin.peer@...adcom.com>,
        Andrew Gospodarek <andrew.gospodarek@...adcom.com>
Subject: Re: [PATCH ethtool] bnxt: Add Broadcom driver support.

On Mon, Sep 21, 2020 at 6:11 PM Andrew Lunn <andrew@...n.ch> wrote:
>
> > +struct bnxt_pcie_stat {
> > +     const char *name;
> > +     u16 offset;
> > +     u8 size;
> > +     const char *format;
> > +};
> > +
> > +static const struct bnxt_pcie_stat bnxt_pcie_stats[] = {
> > +     { .name = "PL Signal integrity errors     ", .offset = 0, .size = 4, .format = "%lld" },
> > +     { .name = "DL Signal integrity errors     ", .offset = 4, .size = 4, .format = "%lld" },
> > +     { .name = "TLP Signal integrity errors    ", .offset = 8, .size = 4, .format = "%lld" },
>
> These look like statistics. Could they be part of ethtool -S
Only a couple of PCIe statistics look like counters. But to have all
PCIe statistics (most of them are not plain counters) at one place,
dumping them in the register dump. Thanks.
>
>       Andrew