netdev - Re: [PATCHv2 bpf-next 1/2] bpf: Use --no-fail option if CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200923184746.GP2893484@krava>
Date:   Wed, 23 Sep 2020 20:47:46 +0200
From:   Jiri Olsa <jolsa@...hat.com>
To:     Andrii Nakryiko <andrii.nakryiko@...il.com>
Cc:     Jiri Olsa <jolsa@...nel.org>, Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andriin@...com>,
        Networking <netdev@...r.kernel.org>, bpf <bpf@...r.kernel.org>,
        Martin KaFai Lau <kafai@...com>,
        Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>,
        John Fastabend <john.fastabend@...il.com>,
        KP Singh <kpsingh@...omium.org>,
        Seth Forshee <seth.forshee@...onical.com>
Subject: Re: [PATCHv2 bpf-next 1/2] bpf: Use --no-fail option if CONFIG_BPF
 is not enabled

On Wed, Sep 23, 2020 at 09:09:17AM -0700, Andrii Nakryiko wrote:
> On Wed, Sep 23, 2020 at 7:06 AM Jiri Olsa <jolsa@...nel.org> wrote:

damn I'm blind this week.. will send v3 with proper subject :-\

jirka

> >
> > Currently all the resolve_btfids 'users' are under CONFIG_BPF
> > code, so if we have CONFIG_BPF disabled, resolve_btfids will
> > fail, because there's no data to resolve.
> >
> > Disabling resolve_btfids if there's CONFIG_BPF disabled,
> > so we won't fail such builds.
> >
> > Suggested-by: Andrii Nakryiko <andriin@...com>
> > Signed-off-by: Jiri Olsa <jolsa@...nel.org>
> > ---
> > v2 changes:
> >   - disable resolve_btfids completely when CONFIG_BPF is not defined
> 
> Acked-by: Andrii Nakryiko <andriin@...com>
> 
> [...]
>