lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 23 Sep 2020 10:43:03 +0200 From: Christoph Hellwig <hch@....de> To: Coly Li <colyli@...e.de> Cc: Christoph Hellwig <hch@....de>, linux-block@...r.kernel.org, linux-nvme@...ts.infradead.org, netdev@...r.kernel.org, open-iscsi@...glegroups.com, linux-scsi@...r.kernel.org, ceph-devel@...r.kernel.org, linux-kernel@...r.kernel.org, Chaitanya Kulkarni <chaitanya.kulkarni@....com>, Hannes Reinecke <hare@...e.de>, Jan Kara <jack@...e.com>, Jens Axboe <axboe@...nel.dk>, Mikhail Skorzhinskii <mskorzhinskiy@...arflare.com>, Philipp Reisner <philipp.reisner@...bit.com>, Sagi Grimberg <sagi@...mberg.me>, Vlastimil Babka <vbabka@...e.com>, stable@...r.kernel.org Subject: Re: [PATCH v7 1/6] net: introduce helper sendpage_ok() in include/linux/net.h On Wed, Aug 19, 2020 at 12:22:05PM +0800, Coly Li wrote: > On 2020/8/19 03:49, Christoph Hellwig wrote: > > On Wed, Aug 19, 2020 at 12:33:37AM +0800, Coly Li wrote: > >> On 2020/8/19 00:24, Christoph Hellwig wrote: > >>> I think we should go for something simple like this instead: > >> > >> This idea is fine to me. Should a warning message be through here? IMHO > >> the driver still sends an improper page in, fix it in silence is too > >> kind or over nice to the buggy driver(s). > > > > I don't think a warning is a good idea. An API that does the right > > thing underneath and doesn't require boiler plate code in most callers > > is the right API. > > > > Then I don't have more comment. So given the feedback from Dave I suspect we should actually resurrect this series, sorry for the noise. And in this case I think we do need the warning in kernel_sendpage.
Powered by blists - more mailing lists