netdev - Re: [PATCH v2] brcmfmac: check return value of driver_for_each

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200924154813.78757C433FF@smtp.codeaurora.org>
Date:   Thu, 24 Sep 2020 15:48:13 +0000 (UTC)
From:   Kalle Valo <kvalo@...eaurora.org>
To:     Zhang Changzhong <zhangchangzhong@...wei.com>
Cc:     <davem@...emloft.net>, <kuba@...nel.org>,
        <linux-wireless@...r.kernel.org>, <netdev@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] brcmfmac: check return value of
 driver_for_each_device()

Zhang Changzhong <zhangchangzhong@...wei.com> wrote:

> Fixes the following W=1 kernel build warning(s):
> 
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c:1576:6: warning:
>  variable 'ret' set but not used [-Wunused-but-set-variable]
>   1576 |  int ret;
>        |      ^~~
> 
> driver_for_each_device() has been declared with __must_check, so the
> return value should be checked.
> 
> Signed-off-by: Zhang Changzhong <zhangchangzhong@...wei.com>

Patch applied to wireless-drivers-next.git, thanks.

72a398a63b88 brcmfmac: check return value of driver_for_each_device()

-- 
https://patchwork.kernel.org/patch/11786561/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches