netdev - Re: [PATCH iproute2] build: avoid make jobserver warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200924091107.1f11508c@hermes.lan>
Date:   Thu, 24 Sep 2020 09:11:07 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Jan Engelhardt <jengelh@...i.de>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH iproute2] build: avoid make jobserver warnings

On Tue, 22 Sep 2020 08:15:59 +0200 (CEST)
Jan Engelhardt <jengelh@...i.de> wrote:

> On Tuesday 2020-09-22 02:19, Stephen Hemminger wrote:
> >> I observe:
> >> 
> >> 	» make -j8 CCOPTS=-ggdb3
> >> 	lib
> >> 	make[1]: warning: -j8 forced in submake: resetting jobserver mode.
> >> 	make[1]: Nothing to be done for 'all'.
> >> 	ip
> >> 	make[1]: warning: -j8 forced in submake: resetting jobserver mode.
> >> 	    CC       ipntable.o
> >> 
> >> MFLAGS is a historic variable of some kind; removing it fixes the
> >> jobserver issue.  
> >
> >MFLAGS is a way to pass flags from original make into the sub-make.  
> 
> MAKEFLAGS and MFLAGS are already exported by make (${MAKE} is magic
> methinks), so they need no explicit passing. You can check this by
> adding something like 'echo ${MAKEFLAGS}' to the lib/Makefile
> libnetlink.a target and then invoking e.g. `make -r` from the
> toplevel, and notice how -r shows up again in the submake.

For context:
https://www.gnu.org/software/make/manual/html_node/Options_002fRecursion.html

With your change does the options through the same?
My concern is that this change might break how distros do their package builds,
and cross compilation.