netdev - Re: [PATCH bpf-next v8 04/11] bpf: move prog->aux->linked_prog and trampoline into bpf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEf4BzaBvvZdgekg13T3e4uj5Q9Rf1RTFP__ZPsU-NMp2fVXxw@mail.gmail.com>
Date:   Thu, 24 Sep 2020 13:40:53 -0700
From:   Andrii Nakryiko <andrii.nakryiko@...il.com>
To:     Toke Høiland-Jørgensen <toke@...hat.com>
Cc:     Alexei Starovoitov <alexei.starovoitov@...il.com>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Martin KaFai Lau <kafai@...com>,
        Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>,
        Andrii Nakryiko <andriin@...com>,
        John Fastabend <john.fastabend@...il.com>,
        Jiri Olsa <jolsa@...hat.com>,
        Eelco Chaudron <echaudro@...hat.com>,
        KP Singh <kpsingh@...omium.org>,
        Networking <netdev@...r.kernel.org>, bpf <bpf@...r.kernel.org>
Subject: Re: [PATCH bpf-next v8 04/11] bpf: move prog->aux->linked_prog and
 trampoline into bpf_link on attach

On Thu, Sep 24, 2020 at 7:36 AM Toke Høiland-Jørgensen <toke@...hat.com> wrote:
>
> Alexei Starovoitov <alexei.starovoitov@...il.com> writes:
>
> > On Tue, Sep 22, 2020 at 08:38:38PM +0200, Toke HÃƒÂ¸iland-JÃƒÂ¸rgensen wrote:
> >> @@ -746,7 +748,9 @@ struct bpf_prog_aux {
> >>      u32 max_rdonly_access;
> >>      u32 max_rdwr_access;
> >>      const struct bpf_ctx_arg_aux *ctx_arg_info;
> >> -    struct bpf_prog *linked_prog;
> >
> > This change breaks bpf_preload and selftests test_bpffs.
> > There is really no excuse not to run the selftests.
>
> I did run the tests, and saw no more breakages after applying my patches
> than before. Which didn't catch this, because this is the current state
> of bpf-next selftests:
>
> # ./test_progs  | grep FAIL
> test_lookup_update:FAIL:map1_leak inner_map1 leaked!
> #10/1 lookup_update:FAIL
> #10 btf_map_in_map:FAIL

this failure suggests you are not running the latest kernel, btw


> configure_stack:FAIL:BPF load failed; run with -vv for more info
> #72 sk_assign:FAIL
> test_test_bpffs:FAIL:bpffs test  failed 255
> #96 test_bpffs:FAIL
> Summary: 113/844 PASSED, 14 SKIPPED, 4 FAILED
>
> The test_bpffs failure happens because the umh is missing from the
> .config; and when I tried to fix this I ended up with:

yeah, seems like selftests/bpf/config needs to be updated to mention
UMH-related config values:

CONFIG_BPF_PRELOAD=y
CONFIG_BPF_PRELOAD_UMD=m|y

with that test_bpffs shouldn't fail on master

>
> [..]
>   CC [M]  kernel/bpf/preload/bpf_preload_kern.o
>
> Auto-detecting system features:
> ...                        libelf: [ OFF ]
> ...                          zlib: [ OFF ]
> ...                           bpf: [ OFF ]
>
> No libelf found

might be worthwhile to look into why detection fails, might be
something with Makefiles or your environment

>
> ...which I just put down to random breakage, turned off the umh and
> continued on my way (ignoring the failed test). Until you wrote this I
> did not suspect this would be something I needed to pay attention to.
> Now that you did mention it, I'll obviously go investigate some more, my
> point is just that in this instance it's not accurate to assume I just
> didn't run the tests... :)

Don't just assume some tests are always broken. Either ask or
investigate on your own. Such cases do happen from time to time while
we wait for a fix in bpf to get merged into bpf-next or vice versa,
but it's rare. We now have two different CI systems running selftests
all the time, in addition to running them locally as well, so any
permanent test failure is very apparent and annoying, so we fix them
quickly. So, when in doubt - ask or fix.

>
> > I think I will just start marking patches as changes-requested when I see that
> > they break tests without replying and without reviewing.
> > Please respect reviewer's time.
>
> That is completely fine if the tests are working in the first place. And

They are and hopefully moving forward that would be your assumption.

> even when they're not (like in this case), pointing it out is fine, and
> I'll obviously go investigate. But please at least reply to the email,
> not all of us watch patchwork regularly.
>
> (I'll fix all your other comments and respin; thanks!)
>
> -Toke
>