netdev - Re: [PATCH bpf-next 5/6] bpf, selftests: use bpf_tail_call

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <600a91d1-bade-c46f-4dc9-24d31daceb55@iogearbox.net>
Date:   Fri, 25 Sep 2020 00:03:40 +0200
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Maciej Fijalkowski <maciej.fijalkowski@...el.com>
Cc:     ast@...nel.org, john.fastabend@...il.com, netdev@...r.kernel.org,
        bpf@...r.kernel.org
Subject: Re: [PATCH bpf-next 5/6] bpf, selftests: use bpf_tail_call_static
 where appropriate

On 9/24/20 9:25 PM, Maciej Fijalkowski wrote:
> On Thu, Sep 24, 2020 at 08:21:26PM +0200, Daniel Borkmann wrote:
>> For those locations where we use an immediate tail call map index use the
>> newly added bpf_tail_call_static() helper.
>>
>> Signed-off-by: Daniel Borkmann <daniel@...earbox.net>
>> ---
>>   tools/testing/selftests/bpf/progs/bpf_flow.c  | 12 ++++----
>>   tools/testing/selftests/bpf/progs/tailcall1.c | 28 +++++++++----------
>>   tools/testing/selftests/bpf/progs/tailcall2.c | 14 +++++-----
>>   tools/testing/selftests/bpf/progs/tailcall3.c |  4 +--
>>   .../selftests/bpf/progs/tailcall_bpf2bpf1.c   |  4 +--
>>   .../selftests/bpf/progs/tailcall_bpf2bpf2.c   |  6 ++--
>>   .../selftests/bpf/progs/tailcall_bpf2bpf3.c   |  6 ++--
>>   .../selftests/bpf/progs/tailcall_bpf2bpf4.c   |  6 ++--
>>   8 files changed, 40 insertions(+), 40 deletions(-)
> 
> One nit, while you're at it, maybe it would be good to also address the
> samples/bpf/sockex3_kern.c that is also using the immediate map index?

Sure, np, will add.