netdev - Re: [PATCH bpf-next v8 11/11] selftests: Remove fmod_ret from benchmarks and test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200924010811.kwrkzdzh6za3w3fz@ast-mbp.dhcp.thefacebook.com>
Date:   Wed, 23 Sep 2020 18:08:11 -0700
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Toke Høiland-Jørgensen <toke@...hat.com>
Cc:     Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Martin KaFai Lau <kafai@...com>,
        Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>,
        Andrii Nakryiko <andriin@...com>,
        John Fastabend <john.fastabend@...il.com>,
        Jiri Olsa <jolsa@...hat.com>,
        Eelco Chaudron <echaudro@...hat.com>,
        KP Singh <kpsingh@...omium.org>, netdev@...r.kernel.org,
        bpf@...r.kernel.org
Subject: Re: [PATCH bpf-next v8 11/11] selftests: Remove fmod_ret from
 benchmarks and test_overhead

On Tue, Sep 22, 2020 at 08:38:45PM +0200, Toke Høiland-Jørgensen wrote:
> -const struct bench bench_trig_fmodret = {
> -	.name = "trig-fmodret",
> -	.validate = trigger_validate,
> -	.setup = trigger_fmodret_setup,
> -	.producer_thread = trigger_producer,
> -	.consumer_thread = trigger_consumer,
> -	.measure = trigger_measure,
> -	.report_progress = hits_drops_report_progress,
> -	.report_final = hits_drops_report_final,
> -};
> diff --git a/tools/testing/selftests/bpf/progs/trigger_bench.c b/tools/testing/selftests/bpf/progs/trigger_bench.c
> index 9a4d09590b3d..1af23ac0c37c 100644
> --- a/tools/testing/selftests/bpf/progs/trigger_bench.c
> +++ b/tools/testing/selftests/bpf/progs/trigger_bench.c
> @@ -45,10 +45,3 @@ int bench_trigger_fentry_sleep(void *ctx)
>  	__sync_add_and_fetch(&hits, 1);
>  	return 0;
>  }
> -
> -SEC("fmod_ret/__x64_sys_getpgid")
> -int bench_trigger_fmodret(void *ctx)
> -{
> -	__sync_add_and_fetch(&hits, 1);
> -	return -22;
> -}

why are you removing this? There is no problem here.
All syscalls are error-injectable.
I'm surprised Andrii acked this :(