netdev - Re: [PATCH] net: mdio: Remove redundant parameter and check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200923.181031.1814913923203712388.davem@davemloft.net>
Date:   Wed, 23 Sep 2020 18:10:31 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     tangbin@...s.chinamobile.com
Cc:     andrew@...n.ch, hkallweit1@...il.com, kuba@...nel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        zhangshengju@...s.chinamobile.com
Subject: Re: [PATCH] net: mdio: Remove redundant parameter and check

From: Tang Bin <tangbin@...s.chinamobile.com>
Date: Wed, 23 Sep 2020 18:05:32 +0800

> @@ -125,12 +124,9 @@ ipq8064_mdio_probe(struct platform_device *pdev)
>  		return PTR_ERR(priv->base);
>  	}
>  
> -	ret = of_mdiobus_register(bus, np);
> -	if (ret)
> -		return ret;
> -
>  	platform_set_drvdata(pdev, bus);
> -	return 0;
> +
> +	return of_mdiobus_register(bus, np);
>  }

You are changing the code rather than simplifying the return sequence.

The author of this code intended the platform_set_drvdata() to only
happen if all operations of this function succeeded.

I am not applying this patch, sorry.