netdev - Re: [MPTCP][PATCH net-next 12/16] selftests: mptcp: add remove cfg in mptcp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.OSX.2.23.453.2009241723580.62831@mmahler-mobl1.amr.corp.intel.com>
Date:   Thu, 24 Sep 2020 17:24:15 -0700 (PDT)
From:   Mat Martineau <mathew.j.martineau@...ux.intel.com>
To:     Geliang Tang <geliangtang@...il.com>
cc:     Matthieu Baerts <matthieu.baerts@...sares.net>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
        mptcp@...ts.01.org, linux-kernel@...r.kernel.org
Subject: Re: [MPTCP][PATCH net-next 12/16] selftests: mptcp: add remove cfg
 in mptcp_connect

On Thu, 24 Sep 2020, Geliang Tang wrote:

> This patch added a new cfg, named cfg_remove in mptcp_connect. This new
> cfg_remove is copied from cfg_join. The only difference between them is in
> the do_rnd_write function. Here we slow down the transfer process of all
> data to let the RM_ADDR suboption can be sent and received completely.
> Otherwise the remove address and subflow test cases don't work.
>
> Suggested-by: Matthieu Baerts <matthieu.baerts@...sares.net>
> Suggested-by: Paolo Abeni <pabeni@...hat.com>
> Suggested-by: Mat Martineau <mathew.j.martineau@...ux.intel.com>
> Acked-by: Paolo Abeni <pabeni@...hat.com>
> Signed-off-by: Geliang Tang <geliangtang@...il.com>
> ---
> .../selftests/net/mptcp/mptcp_connect.c        | 18 +++++++++++++++---
> 1 file changed, 15 insertions(+), 3 deletions(-)

Reviewed-by: Mat Martineau <mathew.j.martineau@...ux.intel.com>

--
Mat Martineau
Intel