netdev - Re: [PATCH v4 bpf-next 02/13] bpf: Enable bpf_skc_to_* sock casting helper to networking prog type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d440f3f8-615c-5fc9-9703-283941ff33c6@fb.com>
Date:   Fri, 25 Sep 2020 08:47:20 -0700
From:   Alexei Starovoitov <ast@...com>
To:     Lorenz Bauer <lmb@...udflare.com>, Martin KaFai Lau <kafai@...com>
CC:     bpf <bpf@...r.kernel.org>, Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Kernel Team <kernel-team@...com>,
        Networking <netdev@...r.kernel.org>
Subject: Re: [PATCH v4 bpf-next 02/13] bpf: Enable bpf_skc_to_* sock casting
 helper to networking prog type

On 9/25/20 6:50 AM, Lorenz Bauer wrote:
>>>> -       for (i = 0; i < ARRAY_SIZE(fn->arg_type); i++)
>>>> +       for (i = 0; i < ARRAY_SIZE(fn->arg_type); i++) {
>>>>                  if (fn->arg_type[i] == ARG_PTR_TO_BTF_ID && !fn->arg_btf_id[i])
>>>>                          return false;
>>>>
>>>> +               if (fn->arg_type[i] != ARG_PTR_TO_BTF_ID && fn->arg_btf_id[i])
>>>> +                       return false;
>>>> +       }
>>>> +
>>> This is a hold over from the previous patchset?
>> hmm... what do you mean?
> Sorry, I misread the patch!

Folks, please trim your replies.
You could have quoted just few lines above instead of most of the patch.
Scrolling takes time for those of us who used tbird, mutt, etc.