netdev - Re: [PATCH] net: ethernet: cavium: octeon_mgmt: use phy_start and phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200925163006.GB3856392@lunn.ch>
Date:   Fri, 25 Sep 2020 18:30:06 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Ivan Khoronzhuk <ivan.khoronzhuk@...il.com>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, kuba@...nel.org,
        alexander.sverdlin@...ia.com, linux-kernel@...r.kernel.org,
        Ivan Khoronzhuk <ikhoronz@...co.com>
Subject: Re: [PATCH] net: ethernet: cavium: octeon_mgmt: use phy_start and
 phy_stop

On Fri, Sep 25, 2020 at 03:44:39PM +0300, Ivan Khoronzhuk wrote:
> To start also "phy state machine", with UP state as it should be,
> the phy_start() has to be used, in another case machine even is not
> triggered. After this change negotiation is supposed to be triggered
> by SM workqueue.
> 
> It's not correct usage, but it appears after the following patch,
> so add it as a fix.
> 
> Fixes: 74a992b3598a ("net: phy: add phy_check_link_status")
> Signed-off-by: Ivan Khoronzhuk <ikhoronz@...co.com>
> ---
> 
> Based on net/master

Hi Ivan

In the future, please make the patch subject [PATCH net] to make it
clear which tree it is for.

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew