netdev - Re: [MPTCP][PATCH net-next 09/16] mptcp: implement mptcp_pm_remove

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.OSX.2.23.453.2009241730590.62831@mmahler-mobl1.amr.corp.intel.com>
Date:   Thu, 24 Sep 2020 17:33:32 -0700 (PDT)
From:   Mat Martineau <mathew.j.martineau@...ux.intel.com>
To:     netdev@...r.kernel.org
Subject: Re: [MPTCP][PATCH net-next 09/16] mptcp: implement
 mptcp_pm_remove_subflow

On Thu, 24 Sep 2020, Geliang Tang wrote:

> This patch implemented the local subflow removing function,
> mptcp_pm_remove_subflow, it simply called mptcp_pm_nl_rm_subflow_received
> under the PM spin lock.
>
> We use mptcp_pm_remove_subflow to remove a local subflow, so change it's
> argument from remote_id to local_id.
>
> We check subflow->local_id in mptcp_pm_nl_rm_subflow_received to remove
> a subflow.
>
> Suggested-by: Matthieu Baerts <matthieu.baerts@...sares.net>
> Suggested-by: Paolo Abeni <pabeni@...hat.com>
> Suggested-by: Mat Martineau <mathew.j.martineau@...ux.intel.com>
> Signed-off-by: Geliang Tang <geliangtang@...il.com>
> ---
> net/mptcp/pm.c         |  9 +++++++--
> net/mptcp/pm_netlink.c | 33 +++++++++++++++++++++++++++++++++
> net/mptcp/protocol.h   |  3 ++-
> 3 files changed, 42 insertions(+), 3 deletions(-)

Resending this reviewed-by tag so patchwork picks it up (previous mail was 
not delivered to the mailing list, but I'm assuming it did go to other 
recipients).

Reviewed-by: Mat Martineau <mathew.j.martineau@...ux.intel.com>

--
Mat Martineau
Intel