netdev - Re: [PATCH] net: stmmac: dwmac-meson8b: add calibration registers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200925.162612.1706734858463106489.davem@davemloft.net>
Date:   Fri, 25 Sep 2020 16:26:12 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     martin.blumenstingl@...glemail.com
Cc:     netdev@...r.kernel.org, linux-amlogic@...ts.infradead.org,
        peppe.cavallaro@...com, alexandre.torgue@...com,
        joabreu@...opsys.com, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: stmmac: dwmac-meson8b: add calibration registers

From: Martin Blumenstingl <martin.blumenstingl@...glemail.com>
Date: Fri, 25 Sep 2020 23:56:29 +0200

> The Amlogic dwmac Ethernet IP glue has two registers:
> - PRG_ETH0 with various configuration bits
> - PRG_ETH1 with various calibration and information related bits
> 
> Add the register definitions with comments from different drivers in
> Amlogic's vendor u-boot and Linux.
> 
> The most important part is PRG_ETH1_AUTO_CALI_IDX_VAL which is needed on
> G12A (and later: G12B, SM1) with RGMII PHYs. Ethernet is only working up
> to 100Mbit/s speeds if u-boot does not initialize these bits correctly.
> On 1Gbit/s links no traffic is flowing (similar to when the RGMII delays
> are set incorrectly). The logic to write this register will be added
> later.
> 
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@...glemail.com>

Please add these definitions alongside actual uses of them.

Thank you.