netdev - Re: [PATCH] net/tls: race causes kernel panic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200924.200730.982972982825728936.davem@davemloft.net>
Date:   Thu, 24 Sep 2020 20:07:30 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     rohitm@...lsio.com
Cc:     kuba@...nel.org, netdev@...r.kernel.org, vakul.garg@....com,
        secdev@...lsio.com
Subject: Re: [PATCH] net/tls: race causes kernel panic

From: Rohit Maheshwari <rohitm@...lsio.com>
Date: Thu, 24 Sep 2020 12:28:45 +0530

> BUG: kernel NULL pointer dereference, address: 00000000000000b8
 ...
>  RIP: 0010:tx_work_handler+0x1b/0x70 [tls]
 ...
>  Call Trace:
>   process_one_work+0x1a7/0x370
>   worker_thread+0x30/0x370
>   ? process_one_work+0x370/0x370
>   kthread+0x114/0x130
>   ? kthread_park+0x80/0x80
>   ret_from_fork+0x22/0x30
> 
> tls_sw_release_resources_tx() waits for encrypt_pending, which
> can have race, so we need similar changes as in commit
> 0cada33241d9de205522e3858b18e506ca5cce2c here as well.
> 
> Fixes: a42055e8d2c3 ("net/tls: Add support for async encryption of records for performance")
> Signed-off-by: Rohit Maheshwari <rohitm@...lsio.com>

Applied and queued up for -stable, thank you.