netdev - Re: [PATCH] net: dsa: microchip: really look for phy-mode in port nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200924.201014.1985667809546779432.davem@davemloft.net>
Date:   Thu, 24 Sep 2020 20:10:14 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     helmut.grohne@...enta.de
Cc:     nicolas.ferre@...rochip.com, alexandre.belloni@...tlin.com,
        ludovic.desroches@...rochip.com, woojung.huh@...rochip.com,
        UNGLinuxDriver@...rochip.com, andrew@...n.ch,
        vivien.didelot@...il.com, f.fainelli@...il.com, kuba@...nel.org,
        robh+dt@...nel.org, devicetree@...r.kernel.org,
        netdev@...r.kernel.org
Subject: Re: [PATCH] net: dsa: microchip: really look for phy-mode in port
 nodes

From: Helmut Grohne <helmut.grohne@...enta.de>
Date: Thu, 24 Sep 2020 10:37:47 +0200

> The previous implementation failed to account for the "ports" node. The
> actual port nodes are not child nodes of the switch node, but a "ports"
> node sits in between.
> 
> Fixes: edecfa98f602 ("net: dsa: microchip: look for phy-mode in port nodes")
> Signed-off-by: Helmut Grohne <helmut.grohne@...enta.de>

Applied and queued up for -stable.

> I am very sorry that I need to send a fixup. It turned out that my
> testing methodology was flawed. When I reintegrated Linus' master
> branch, I noticed that it didn't work.

You should be testing against the 'net' GIT tree, not Linus's master
branch.