netdev - Re: [PATCH net] tcp: skip DSACKs with dubious sequence ranges

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200924.201638.1709163985407685775.davem@davemloft.net>
Date:   Thu, 24 Sep 2020 20:16:38 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     priyarjha.kernel@...il.com
Cc:     netdev@...r.kernel.org, priyarjha@...gle.com, ncardwell@...gle.com,
        ycheng@...gle.com, edumazet@...gle.com
Subject: Re: [PATCH net] tcp: skip DSACKs with dubious sequence ranges

From: Priyaranjan Jha <priyarjha.kernel@...il.com>
Date: Thu, 24 Sep 2020 15:23:14 -0700

> From: Priyaranjan Jha <priyarjha@...gle.com>
> 
> Currently, we use length of DSACKed range to compute number of
> delivered packets. And if sequence range in DSACK is corrupted,
> we can get bogus dsacked/acked count, and bogus cwnd.
> 
> This patch put bounds on DSACKed range to skip update of data
> delivery and spurious retransmission information, if the DSACK
> is unlikely caused by sender's action:
> - DSACKed range shouldn't be greater than maximum advertised rwnd.
> - Total no. of DSACKed segments shouldn't be greater than total
>   no. of retransmitted segs. Unlike spurious retransmits, network
>   duplicates or corrupted DSACKs shouldn't be counted as delivery.
> 
> Signed-off-by: Priyaranjan Jha <priyarjha@...gle.com>
> Signed-off-by: Neal Cardwell <ncardwell@...gle.com>
> Signed-off-by: Yuchung Cheng <ycheng@...gle.com>
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Applied and queued up for -stable, thanks.