lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 24 Sep 2020 20:55:41 -0700 From: Alexei Starovoitov <alexei.starovoitov@...il.com> To: Andrii Nakryiko <andriin@...com> Cc: bpf@...r.kernel.org, netdev@...r.kernel.org, ast@...com, daniel@...earbox.net, andrii.nakryiko@...il.com, kernel-team@...com, Arnaldo Carvalho de Melo <acme@...hat.com> Subject: Re: [PATCH bpf-next 7/9] libbpf: add BTF writing APIs On Wed, Sep 23, 2020 at 08:54:34AM -0700, Andrii Nakryiko wrote: > Add APIs for appending new BTF types at the end of BTF object. > > Each BTF kind has either one API of the form btf__append_<kind>(). For types > that have variable amount of additional items (struct/union, enum, func_proto, > datasec), additional API is provided to emit each such item. E.g., for > emitting a struct, one would use the following sequence of API calls: > > btf__append_struct(...); > btf__append_field(...); > ... > btf__append_field(...); I've just started looking through the diffs. The first thing that struck me is the name :) Why 'append' instead of 'add' ? The latter is shorter. Also how would you add anon struct that is within another struct ? The anon one would have to be added first and then added as a field? Feels a bit odd that struct/union building doesn't have 'finish' method, but I guess it can work.
Powered by blists - more mailing lists