netdev - Re: [PATCH net-next v2 1/7] net: devlink: Add unused port flavour

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200926215147.w7xjlozqs6i5pffm@skbuf>
Date:   Sun, 27 Sep 2020 00:51:47 +0300
From:   Vladimir Oltean <olteanv@...il.com>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     David Miller <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>,
        Florian Fainelli <f.fainelli@...il.com>,
        Vladimir Oltean <vladimir.oltean@....com>,
        Jiri Pirko <jiri@...dia.com>, Jakub Kicinski <kuba@...nel.org>
Subject: Re: [PATCH net-next v2 1/7] net: devlink: Add unused port flavour

On Sat, Sep 26, 2020 at 11:06:26PM +0200, Andrew Lunn wrote:
> Not all ports of a switch need to be used, particularly in embedded
> systems. Add a port flavour for ports which physically exist in the
> switch, but are not connected to the front panel etc, and so are
> unused.
> 
> Signed-off-by: Andrew Lunn <andrew@...n.ch>
> ---
>  include/uapi/linux/devlink.h | 3 +++
>  net/core/devlink.c           | 4 +++-
>  2 files changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/include/uapi/linux/devlink.h b/include/uapi/linux/devlink.h
> index a2ecc8b00611..e1f209feac74 100644
> --- a/include/uapi/linux/devlink.h
> +++ b/include/uapi/linux/devlink.h
> @@ -195,6 +195,9 @@ enum devlink_port_flavour {
>  				      * port that faces the PCI VF.
>  				      */
>  	DEVLINK_PORT_FLAVOUR_VIRTUAL, /* Any virtual port facing the user. */
> +	DEVLINK_PORT_FLAVOUR_UNUSED, /* Port which exists in the switch, but
> +				      *	is not used in any way.

Nitpicking: there is an extraneous tab character here between "*" and "is".

> +				      */
>  };
>  
>  enum devlink_param_cmode {
> diff --git a/net/core/devlink.c b/net/core/devlink.c
> index ac32b672a04b..fc9589eb4115 100644
> --- a/net/core/devlink.c
> +++ b/net/core/devlink.c
> @@ -7569,7 +7569,8 @@ static bool devlink_port_type_should_warn(struct devlink_port *devlink_port)
>  {
>  	/* Ignore CPU and DSA flavours. */
>  	return devlink_port->attrs.flavour != DEVLINK_PORT_FLAVOUR_CPU &&
> -	       devlink_port->attrs.flavour != DEVLINK_PORT_FLAVOUR_DSA;
> +	       devlink_port->attrs.flavour != DEVLINK_PORT_FLAVOUR_DSA &&
> +	       devlink_port->attrs.flavour != DEVLINK_PORT_FLAVOUR_UNUSED;
>  }
>  
>  #define DEVLINK_PORT_TYPE_WARN_TIMEOUT (HZ * 3600)
> @@ -7854,6 +7855,7 @@ static int __devlink_port_phys_port_name_get(struct devlink_port *devlink_port,
>  		break;
>  	case DEVLINK_PORT_FLAVOUR_CPU:
>  	case DEVLINK_PORT_FLAVOUR_DSA:
> +	case DEVLINK_PORT_FLAVOUR_UNUSED:
>  		/* As CPU and DSA ports do not have a netdevice associated
>  		 * case should not ever happen.
>  		 */
> -- 
> 2.28.0
>