netdev - Re: [PATCH net] mlxsw: spectrum_acl: Fix mlxsw_sp_acl_tcam_group

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200927.132400.700160456852122583.davem@davemloft.net>
Date:   Sun, 27 Sep 2020 13:24:00 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     idosch@...sch.org
Cc:     netdev@...r.kernel.org, kuba@...nel.org, jiri@...dia.com,
        mlxsw@...dia.com, idosch@...dia.com
Subject: Re: [PATCH net] mlxsw: spectrum_acl: Fix
 mlxsw_sp_acl_tcam_group_add()'s error path

From: Ido Schimmel <idosch@...sch.org>
Date: Sun, 27 Sep 2020 09:42:11 +0300

> From: Ido Schimmel <idosch@...dia.com>
> 
> If mlxsw_sp_acl_tcam_group_id_get() fails, the mutex initialized earlier
> is not destroyed.
> 
> Fix this by initializing the mutex after calling the function. This is
> symmetric to mlxsw_sp_acl_tcam_group_del().
> 
> Fixes: 5ec2ee28d27b ("mlxsw: spectrum_acl: Introduce a mutex to guard region list updates")
> Signed-off-by: Ido Schimmel <idosch@...dia.com>
> Reviewed-by: Jiri Pirko <jiri@...dia.com>

Applied and queued up for -stable.