netdev - Re: [patch 00/35] net: in_interrupt() cleanup and fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87blhqkxkx.fsf@nanos.tec.linutronix.de>
Date:   Mon, 28 Sep 2020 12:25:02 +0200
From:   Thomas Gleixner <tglx@...utronix.de>
To:     David Miller <davem@...emloft.net>
Cc:     linux-kernel@...r.kernel.org, peterz@...radead.org,
        torvalds@...uxfoundation.org, paulmck@...nel.org,
        willy@...radead.org, benve@...co.com, _govind@....com,
        kuba@...nel.org, netdev@...r.kernel.org, corbet@....net,
        mchehab+huawei@...nel.org, linux-doc@...r.kernel.org,
        bigeasy@...utronix.de, luc.vanoostenryck@...il.com,
        jcliburn@...il.com, chris.snook@...il.com, vishal@...lsio.com,
        jeffrey.t.kirsher@...el.com, intel-wired-lan@...ts.osuosl.org,
        snelson@...sando.io, drivers@...sando.io, andrew@...n.ch,
        hkallweit1@...il.com, linux@...linux.org.uk,
        tsbogend@...ha.franken.de, linux-net-drivers@...arflare.com,
        ecree@...arflare.com, mhabets@...arflare.com, jdmason@...zu.us,
        dsd@...too.org, kune@...ne-taler.de, kvalo@...eaurora.org,
        linux-wireless@...r.kernel.org, linux-usb@...r.kernel.org,
        gregkh@...uxfoundation.org, arend.vanspriel@...adcom.com,
        franky.lin@...adcom.com, hante.meuleman@...adcom.com,
        chi-hsien.lin@...ress.com, wright.feng@...ress.com,
        brcm80211-dev-list.pdl@...adcom.com,
        brcm80211-dev-list@...ress.com, stas.yakovlev@...il.com,
        stf_xl@...pl, johannes.berg@...el.com, emmanuel.grumbach@...el.com,
        luciano.coelho@...el.com, linuxwifi@...el.com
Subject: Re: [patch 00/35] net: in_interrupt() cleanup and fixes

On Sun, Sep 27 2020 at 13:57, David Miller wrote:

> From: Thomas Gleixner <tglx@...utronix.de>
> Date: Sun, 27 Sep 2020 21:48:46 +0200
>
>> in the discussion about preempt count consistency accross kernel configurations:
>
> Please respin this against net-next, some of the patches in here are already
> in net-next (the wireless debug macro one) and even after that the series
> doesn't build:

Will do.

> drivers/net/ethernet/cisco/enic/enic_main.c: In function ‘enic_reset’:
> drivers/net/ethernet/cisco/enic/enic_main.c:2315:2: error: implicit declaration of function ‘enic_set_api_state’; did you mean ‘enic_set_api_busy’? [-Werror=implicit-function-declaration]
>  2315 |  enic_set_api_state(enic, true);
>       |  ^~~~~~~~~~~~~~~~~~
>       |  enic_set_api_busy
> At top level:
> drivers/net/ethernet/cisco/enic/enic_main.c:2298:13: warning: ‘enic_set_api_busy’ defined but not used [-Wunused-function]
>  2298 | static void enic_set_api_busy(struct enic *enic, bool busy)
>       |             ^~~~~~~~~~~~~~~~~

Duh, not sure how I managed that. Sorry. will fix and rebase.

Thanks,

        tglx