netdev - Re: [PATCH ethtool v3 1/3] Add missing 400000base modes for dump_link

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200928163744.pjajgxgbnj6apf3b@lion.mk-sys.cz>
Date:   Mon, 28 Sep 2020 18:37:44 +0200
From:   Michal Kubecek <mkubecek@...e.cz>
To:     Dan Murphy <dmurphy@...com>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH ethtool v3 1/3] Add missing 400000base modes for
 dump_link_caps

On Mon, Sep 28, 2020 at 09:44:01AM -0500, Dan Murphy wrote:
> Commit 63130d0b00040 ("update link mode tables") missed adding in the
> 400000base link_caps to the array.
> 
> Signed-off-by: Dan Murphy <dmurphy@...com>
> ---

I'm sorry, I only found these patches shortly after I pushed similar
update as I needed updated UAPI headers for new format descriptions.

Michal

>  ethtool.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/ethtool.c b/ethtool.c
> index 4f93c0f96985..974b14063de2 100644
> --- a/ethtool.c
> +++ b/ethtool.c
> @@ -659,6 +659,16 @@ static void dump_link_caps(const char *prefix, const char *an_prefix,
>  		  "200000baseDR4/Full" },
>  		{ 0, ETHTOOL_LINK_MODE_200000baseCR4_Full_BIT,
>  		  "200000baseCR4/Full" },
> +		{ 0, ETHTOOL_LINK_MODE_400000baseKR4_Full_BIT,
> +		  "400000baseKR4/Full" },
> +		{ 0, ETHTOOL_LINK_MODE_400000baseSR4_Full_BIT,
> +		  "400000baseSR4/Full" },
> +		{ 0, ETHTOOL_LINK_MODE_400000baseLR4_ER4_FR4_Full_BIT,
> +		  "400000baseLR4_ER4_FR4/Full" },
> +		{ 0, ETHTOOL_LINK_MODE_400000baseDR4_Full_BIT,
> +		  "400000baseDR4/Full" },
> +		{ 0, ETHTOOL_LINK_MODE_400000baseCR4_Full_BIT,
> +		  "400000baseCR4/Full" },
>  	};
>  	int indent;
>  	int did1, new_line_pend;
> -- 
> 2.28.0.585.ge1cfff676549
> 

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)