netdev - Re: [net-next 01/15] igb: add XDP support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200928153003.077836c7@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Mon, 28 Sep 2020 15:30:03 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Tony Nguyen <anthony.l.nguyen@...el.com>
Cc:     davem@...emloft.net, Sven Auhagen <sven.auhagen@...eatech.de>,
        netdev@...r.kernel.org, nhorman@...hat.com, sassmann@...hat.com,
        Sandeep Penigalapati <sandeep.penigalapati@...el.com>
Subject: Re: [net-next 01/15] igb: add XDP support

On Mon, 28 Sep 2020 10:58:54 -0700 Tony Nguyen wrote:
> From: Sven Auhagen <sven.auhagen@...eatech.de>
> 
> Add XDP support to the IGB driver.
> The implementation follows the IXGBE XDP implementation
> closely and I used the following patches as basis:
> 
> 1. commit 924708081629 ("ixgbe: add XDP support for pass and drop actions")
> 2. commit 33fdc82f0883 ("ixgbe: add support for XDP_TX action")
> 3. commit ed93a3987128 ("ixgbe: tweak page counting for XDP_REDIRECT")
> 
> Due to the hardware constraints of the devices using the
> IGB driver we must share the TX queues with XDP which
> means locking the TX queue for XDP.
> 
> I ran tests on an older device to get better numbers.
> Test machine:
> 
> Intel(R) Atom(TM) CPU C2338 @ 1.74GHz (2 Cores)
> 2x Intel I211
> 
> Routing Original Driver Network Stack: 382 Kpps
> 
> Routing XDP Redirect (xdp_fwd_kern): 1.48 Mpps
> XDP Drop: 1.48 Mpps
> 
> Using XDP we can achieve line rate forwarding even on
> an older Intel Atom CPU.
> 
> Signed-off-by: Sven Auhagen <sven.auhagen@...eatech.de>
> Tested-by: Sandeep Penigalapati <sandeep.penigalapati@...el.com>
> Signed-off-by: Tony Nguyen <anthony.l.nguyen@...el.com>

Also some new sparse warnings added here:

drivers/net/ethernet/intel/igb/igb_main.c:6282:23: warning: incorrect type in assignment (different base types)
drivers/net/ethernet/intel/igb/igb_main.c:6282:23:    expected unsigned int [usertype] olinfo_status
drivers/net/ethernet/intel/igb/igb_main.c:6282:23:    got restricted __le32 [usertype]
drivers/net/ethernet/intel/igb/igb_main.c:6287:37: warning: incorrect type in assignment (different base types)
drivers/net/ethernet/intel/igb/igb_main.c:6287:37:    expected restricted __le32 [usertype] olinfo_status
drivers/net/ethernet/intel/igb/igb_main.c:6287:37:    got unsigned int [assigned] [usertype] olinfo_status