lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Mon, 28 Sep 2020 10:03:25 +0200
From:   Arend Van Spriel <>
To:     Thomas Gleixner <>,
        LKML <>
CC:     Peter Zijlstra <>,
        Linus Torvalds <>,
        Paul McKenney <>,
        Matthew Wilcox <>,
        Sebastian Andrzej Siewior <>,
        Franky Lin <>,
        Hante Meuleman <>,
        Kalle Valo <>,
        "David S. Miller" <>,
        Jakub Kicinski <>,
        <>, <>,
        Christian Benvenuti <>,
        Govindarajulu Varadarajan <>,
        Jonathan Corbet <>,
        Mauro Carvalho Chehab <>,
        Luc Van Oostenryck <>,
        Jay Cliburn <>,
        Chris Snook <>,
        Vishal Kulkarni <>,
        Jeff Kirsher <>,
        Shannon Nelson <>,
        Pensando Drivers <>,
        Andrew Lunn <>,
        Heiner Kallweit <>,
        Russell King <>,
        Thomas Bogendoerfer <>,
        Solarflare linux maintainers <>,
        Edward Cree <>,
        Martin Habets <>,
        Jon Mason <>, Daniel Drake <>,
        Ulrich Kunitz <>,
        Greg Kroah-Hartman <>,
        Chi-Hsien Lin <>,
        Wright Feng <>,
        Stanislav Yakovlev <>,
        Stanislaw Gruszka <>,
        Johannes Berg <>,
        Emmanuel Grumbach <>,
        Luca Coelho <>,
        Intel Linux Wireless <>,
        Jouni Malinen <>,
        Amitkumar Karwar <>,
        Ganapathi Bhat <>,
        Xinming Hu <>,
        Pascal Terjan <>,
        Ping-Ke Shih <>
Subject: Re: [patch 25/35] net: brcmfmac: Use netif_rx_any_context().

On 9/27/2020 9:49 PM, Thomas Gleixner wrote:
> From: Sebastian Andrzej Siewior <>
> The usage of in_interrupt() in non-core code is phased out. Ideally the
> information of the calling context should be passed by the callers or the
> functions be split as appropriate.
> brcmfmac uses in_interupt() to select the netif_rx*() variant which matches
> the calling context. The attempt to consolidate the code by passing an
> arguemnt or by distangling it failed due lack of knowledge about this
> driver and because the call chains are convoluted and hard to follow.

I think it is only for USB devices that the function can be called in
"interrupt" context. PCIe devices call it from thread context for sure.
The function brcmf_netif_rx() is (in)directly called by brcmf_rx_frame(), 
which is used by SDIO and USB. Anyway, it will be a bit more work, but 
doable. Let me see what I can come up with.


Download attachment "smime.p7s" of type "application/pkcs7-signature" (4176 bytes)

Powered by blists - more mailing lists