netdev - Re: [PATCH v3 -next] vdpa: mlx5: change Kconfig depends to fix build errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200929060142.GA120395@mtl-vdi-166.wap.labs.mlnx>
Date:   Tue, 29 Sep 2020 09:01:42 +0300
From:   Eli Cohen <elic@...dia.com>
To:     "Michael S. Tsirkin" <mst@...hat.com>
CC:     Leon Romanovsky <leonro@...dia.com>,
        Randy Dunlap <rdunlap@...radead.org>,
        <virtualization@...ts.linux-foundation.org>,
        LKML <linux-kernel@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Jason Wang <jasowang@...hat.com>,
        Saeed Mahameed <saeedm@...dia.com>
Subject: Re: [PATCH v3 -next] vdpa: mlx5: change Kconfig depends to fix build
 errors

On Fri, Sep 25, 2020 at 06:20:45AM -0400, Michael S. Tsirkin wrote:
> > > 
> > > Hmm other drivers select VHOST_IOTLB, why not do the same?
> > 
> > I can't see another driver doing that.
> 
> Well grep VHOST_IOTLB and you will see some examples.

$ git grep -wn VHOST_IOTLB
drivers/vhost/Kconfig:2:config VHOST_IOTLB
drivers/vhost/Kconfig:11:       select VHOST_IOTLB
drivers/vhost/Kconfig:18:       select VHOST_IOTLB

What am I missing here?

> > Perhaps I can set dependency on
> > VHOST which by itself depends on VHOST_IOTLB?
> 
> VHOST is processing virtio in the kernel. You don't really need that
> for mlx, do you?
> 
> > > 
> > > 
> > > > >  	help
> > > > >  	  Support library for Mellanox VDPA drivers. Provides code that is
> > > > >
> > > 
>