netdev - Re: [PATCH 1/2] net: qrtr: Allow forwarded services

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200929143419.GD71055@builder.lan>
Date:   Tue, 29 Sep 2020 09:34:19 -0500
From:   Bjorn Andersson <bjorn.andersson@...aro.org>
To:     Loic Poulain <loic.poulain@...aro.org>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, clew@...eaurora.org,
        manivannan.sadhasivam@...aro.org
Subject: Re: [PATCH 1/2] net: qrtr: Allow forwarded services

On Tue 29 Sep 08:33 CDT 2020, Loic Poulain wrote:

> A remote endpoint (immediate neighbor node) can forward services
> from other non-immediate nodes, in that case ctrl packet node ID
> (offering distant service) can differ from the qrtr source node
> (forwarding the packet).
> 
> Signed-off-by: Loic Poulain <loic.poulain@...aro.org>

Reviewed-by: Bjorn Andersson <bjorn.andersson@...aro.org>

Regards,
Bjorn

> ---
>  net/qrtr/ns.c | 8 --------
>  1 file changed, 8 deletions(-)
> 
> diff --git a/net/qrtr/ns.c b/net/qrtr/ns.c
> index d8252fd..d542d8f 100644
> --- a/net/qrtr/ns.c
> +++ b/net/qrtr/ns.c
> @@ -469,10 +469,6 @@ static int ctrl_cmd_new_server(struct sockaddr_qrtr *from,
>  		port = from->sq_port;
>  	}
>  
> -	/* Don't accept spoofed messages */
> -	if (from->sq_node != node_id)
> -		return -EINVAL;
> -
>  	srv = server_add(service, instance, node_id, port);
>  	if (!srv)
>  		return -EINVAL;
> @@ -511,10 +507,6 @@ static int ctrl_cmd_del_server(struct sockaddr_qrtr *from,
>  		port = from->sq_port;
>  	}
>  
> -	/* Don't accept spoofed messages */
> -	if (from->sq_node != node_id)
> -		return -EINVAL;
> -
>  	/* Local servers may only unregister themselves */
>  	if (from->sq_node == qrtr_ns.local_node && from->sq_port != port)
>  		return -EINVAL;
> -- 
> 2.7.4
>