netdev - Re: [PATCH bpf-next] selftests/bpf_iter: don't fail test due to missing __builtin_btf_type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87zh5821dx.fsf@toke.dk>
Date:   Tue, 29 Sep 2020 14:50:02 +0200
From:   Toke Høiland-Jørgensen <toke@...hat.com>
To:     Alan Maguire <alan.maguire@...cle.com>
Cc:     daniel@...earbox.net, ast@...com, bpf@...r.kernel.org,
        netdev@...r.kernel.org, Alan Maguire <alan.maguire@...cle.com>
Subject: Re: [PATCH bpf-next] selftests/bpf_iter: don't fail test due to
 missing __builtin_btf_type_id

Alan Maguire <alan.maguire@...cle.com> writes:

> On Tue, 29 Sep 2020, Toke Høiland-Jørgensen wrote:
>
>> The new test for task iteration in bpf_iter checks (in do_btf_read()) if it
>> should be skipped due to missing __builtin_btf_type_id. However, this
>> 'skip' verdict is not propagated to the caller, so the parent test will
>> still fail. Fix this by also skipping the rest of the parent test if the
>> skip condition was reached.
>> 
>> Fixes: b72091bd4ee4 ("selftests/bpf: Add test for bpf_seq_printf_btf helper")
>> Signed-off-by: Toke Høiland-Jørgensen <toke@...hat.com>
>
> Reviewed-by: Alan Maguire <alan.maguire@...cle.com>
>
> Thanks for fixing this Toke!

You're welcome! :)

-Toke