netdev - Re: [PATCH][next] dpaa2-mac: Fix potential null pointer dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200929131437.GB28922@embeddedor>
Date:   Tue, 29 Sep 2020 08:14:37 -0500
From:   "Gustavo A. R. Silva" <gustavoars@...nel.org>
To:     David Miller <davem@...emloft.net>
Cc:     ioana.ciornei@....com, ruxandra.radulescu@....com, kuba@...nel.org,
        andrew@...n.ch, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] dpaa2-mac: Fix potential null pointer dereference

On Fri, Sep 25, 2020 at 05:15:54PM -0700, David Miller wrote:
> From: "Gustavo A. R. Silva" <gustavoars@...nel.org>
> Date: Fri, 25 Sep 2020 12:03:23 -0500
> 
> > There is a null-check for _pcs_, but it is being dereferenced
> > prior to this null-check. So, if _pcs_ can actually be null,
> > then there is a potential null pointer dereference that should
> > be fixed by null-checking _pcs_ before being dereferenced.
> > 
> > Addresses-Coverity-ID: 1497159 ("Dereference before null check")
> > Fixes: 94ae899b2096 ("dpaa2-mac: add PCS support through the Lynx module")
> > Signed-off-by: Gustavo A. R. Silva <gustavoars@...nel.org>
> 
> Applied, thanks.

Thanks, Dave.
--
Gustavo