netdev - Re: [PATCH] powerpc: net: bpf_jit_comp: Fix misuse of fallthrough

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d73d30b7-6405-3b42-693f-5e16c7a4c6a3@iogearbox.net>
Date:   Tue, 29 Sep 2020 16:41:49 +0200
From:   Daniel Borkmann <daniel@...earbox.net>
To:     zhe.he@...driver.com, gustavo@...eddedor.com,
        netdev@...r.kernel.org, bpf@...r.kernel.org,
        linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] powerpc: net: bpf_jit_comp: Fix misuse of fallthrough

On 9/28/20 11:00 AM, zhe.he@...driver.com wrote:
> From: He Zhe <zhe.he@...driver.com>
> 
> The user defined label following "fallthrough" is not considered by GCC
> and causes build failure.
> 
> kernel-source/include/linux/compiler_attributes.h:208:41: error: attribute
> 'fallthrough' not preceding a case label or default label [-Werror]
>   208   define fallthrough _attribute((fallthrough_))
>                            ^~~~~~~~~~~~~
> 
> Signed-off-by: He Zhe <zhe.he@...driver.com>

Applied, thanks! I've also added Fixes tag with df561f6688fe ("treewide: Use fallthrough pseudo-keyword")
which added the bug.