netdev - Re: [PATCH bpf-next] selftests: Make sure all 'skel' variables are declared static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAADnVQJt=Sj86-r9y_KvzCuLQU_r=kw4b+=fFx5-EYSA6SAeKQ@mail.gmail.com>
Date:   Tue, 29 Sep 2020 11:46:05 -0700
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Toke Høiland-Jørgensen <toke@...hat.com>
Cc:     Daniel Borkmann <daniel@...earbox.net>,
        Alexei Starovoitov <ast@...com>, bpf <bpf@...r.kernel.org>,
        Network Development <netdev@...r.kernel.org>,
        Martin KaFai Lau <kafai@...com>
Subject: Re: [PATCH bpf-next] selftests: Make sure all 'skel' variables are
 declared static

On Tue, Sep 29, 2020 at 5:32 AM Toke Høiland-Jørgensen <toke@...hat.com> wrote:
>
> If programs in prog_tests using skeletons declare the 'skel' variable as
> global but not static, that will lead to linker errors on the final link of
> the prog_tests binary due to duplicate symbols. Fix a few instances of this.
>
> Fixes: b18c1f0aa477 ("bpf: selftest: Adapt sock_fields test to use skel and global variables")
> Fixes: 9a856cae2217 ("bpf: selftest: Add test_btf_skc_cls_ingress")
> Signed-off-by: Toke Høiland-Jørgensen <toke@...hat.com>

Thanks for the fix. Applied.
I wonder why we don't see it with different gcc and clang versions.
What linker do you use?
And what kind of error do you see?