netdev - Re: [PATCH] mac80211_hwsim: close the race between running and enqueuing hrtimer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <87blhojsav.fsf@nanos.tec.linutronix.de>
Date:   Tue, 29 Sep 2020 21:28:56 +0200
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Hillf Danton <hdanton@...a.com>,
        Johannes Berg <johannes.berg@...el.com>
Cc:     syzbot <syzbot+ca740b95a16399ceb9a5@...kaller.appspotmail.com>,
        davem@...emloft.net, hchunhui@...l.ustc.edu.cn, ja@....bg,
        jmorris@...ei.org, kuznet@....inr.ac.ru,
        linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        syzkaller-bugs@...glegroups.com, yoshfuji@...ux-ipv6.org,
        Hillf Danton <hdanton@...a.com>
Subject: Re: [PATCH] mac80211_hwsim: close the race between running and enqueuing hrtimer

On Tue, Sep 29 2020 at 16:57, Hillf Danton wrote:
> So the timer was armed at some point and then the expiry which does the
> forward races with the ioctl which starts the timer. Lack of
> serialization or such ...
> ===
>
> To close the race, replace hrtimer_is_queued() with hrtimer_active() on
> enqueuing timer, because it also covers the case of a running timer in
> addition to the queued one.
>
> Link: https://lore.kernel.org/lkml/87pn65khft.fsf@nanos.tec.linutronix.de/
> Reported-by: syzbot+ca740b95a16399ceb9a5@...kaller.appspotmail.com
> Decoded-by: Thomas Gleixner <tglx@...utronix.de>
> Signed-off-by: Hillf Danton <hdanton@...a.com>

Reviewed-by: Thomas Gleixner <tglx@...utronix.de>