netdev - Re: [patch V2 33/36] net: libertas: Use netif_rx_any

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200929215302.GB16571@laptop.org>
Date:   Wed, 30 Sep 2020 07:53:03 +1000
From:   James Cameron <quozl@...top.org>
To:     Thomas Gleixner <tglx@...utronix.de>
Cc:     LKML <linux-kernel@...r.kernel.org>, Andrew Lunn <andrew@...n.ch>,
        Emmanuel Grumbach <emmanuel.grumbach@...el.com>,
        linux-doc@...r.kernel.org, Peter Zijlstra <peterz@...radead.org>,
        Chris Snook <chris.snook@...il.com>,
        Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
        Christian Benvenuti <benve@...co.com>,
        Arend van Spriel <arend.vanspriel@...adcom.com>,
        Govindarajulu Varadarajan <_govind@....com>,
        Vishal Kulkarni <vishal@...lsio.com>,
        Luca Coelho <luciano.coelho@...el.com>,
        Edward Cree <ecree@...arflare.com>,
        libertas-dev@...ts.infradead.org, brcm80211-dev-list@...ress.com,
        brcm80211-dev-list.pdl@...adcom.com,
        Ping-Ke Shih <pkshih@...ltek.com>,
        Johannes Berg <johannes.berg@...el.com>,
        Jonathan Corbet <corbet@....net>,
        Mauro Carvalho Chehab <mchehab+huawei@...nel.org>,
        Intel Linux Wireless <linuxwifi@...el.com>,
        Russell King <linux@...linux.org.uk>,
        Matthew Wilcox <willy@...radead.org>,
        intel-wired-lan@...ts.osuosl.org,
        Jeff Kirsher <jeffrey.t.kirsher@...el.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Martin Habets <mhabets@...arflare.com>,
        Ulrich Kunitz <kune@...ne-taler.de>,
        Jay Cliburn <jcliburn@...il.com>,
        Paul McKenney <paulmck@...nel.org>,
        Stanislaw Gruszka <stf_xl@...pl>, Jouni Malinen <j@...fi>,
        Hante Meuleman <hante.meuleman@...adcom.com>,
        Pascal Terjan <pterjan@...gle.com>,
        Amitkumar Karwar <amitkarwar@...il.com>,
        Wright Feng <wright.feng@...ress.com>,
        Daniel Drake <dsd@...too.org>,
        Pensando Drivers <drivers@...sando.io>,
        Kalle Valo <kvalo@...eaurora.org>,
        Franky Lin <franky.lin@...adcom.com>,
        Solarflare linux maintainers <linux-net-drivers@...arflare.com>,
        Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
        Chi-Hsien Lin <chi-hsien.lin@...ress.com>,
        Xinming Hu <huxinming820@...il.com>, netdev@...r.kernel.org,
        linux-usb@...r.kernel.org, linux-wireless@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Ganapathi Bhat <ganapathi.bhat@....com>,
        Stanislav Yakovlev <stas.yakovlev@...il.com>,
        Jon Mason <jdmason@...zu.us>,
        Shannon Nelson <snelson@...sando.io>,
        Dave Miller <davem@...emloft.net>,
        Luc Van Oostenryck <luc.vanoostenryck@...il.com>,
        Heiner Kallweit <hkallweit1@...il.com>
Subject: Re: [patch V2 33/36] net: libertas: Use netif_rx_any_context()

On Tue, Sep 29, 2020 at 10:25:42PM +0200, Thomas Gleixner wrote:
> From: Sebastian Andrzej Siewior <bigeasy@...utronix.de>
> 
> The usage of in_interrupt() in non-core code is phased out. Ideally the
> information of the calling context should be passed by the callers or the
> functions be split as appropriate.
> 
> libertas uses in_interupt() to select the netif_rx*() variant which matches
> the calling context. The attempt to consolidate the code by passing an
> arguemnt or by distangling it failed due lack of knowledge about this
> driver and because the call chains are hard to follow.
> 
> As a stop gap use netif_rx_any_context() which invokes the correct code
> path depending on context and confines the in_interrupt() usage to core
> code.
> 
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@...utronix.de>
> Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
> Acked-by: Kalle Valo <kvalo@...eaurora.org>

Reviewed-by: James Cameron <quozl@...top.org>

-- 
James Cameron
http://quozl.netrek.org/