netdev - Re: [PATCH net v2] ethtool: mark netlink family as __ro_after

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 28 Sep 2020 18:53:12 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     kuba@...nel.org
Cc:     mkubecek@...e.cz, netdev@...r.kernel.org
Subject: Re: [PATCH net v2] ethtool: mark netlink family as __ro_after_init

From: Jakub Kicinski <kuba@...nel.org>
Date: Mon, 28 Sep 2020 17:58:41 -0700

> Like all genl families ethtool_genl_family needs to not
> be a straight up constant, because it's modified/initialized
> by genl_register_family(). After init, however, it's only
> passed to genlmsg_put() & co. therefore we can mark it
> as __ro_after_init.
> 
> Since genl_family structure contains function pointers
> mark this as a fix.
> 
> Fixes: 2b4a8990b7df ("ethtool: introduce ethtool netlink interface")
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Applied.