netdev - Re: [PATCH v2 bpf-next 1/2] bpf: introduce BPF_F_PRESERVE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <08306754-3A1F-412C-98EB-448A1348A6DA@fb.com>
Date:   Wed, 30 Sep 2020 15:04:13 +0000
From:   Song Liu <songliubraving@...com>
To:     Daniel Borkmann <daniel@...earbox.net>
CC:     Network Development <netdev@...r.kernel.org>,
        bpf <bpf@...r.kernel.org>, Kernel Team <Kernel-team@...com>,
        Alexei Starovoitov <ast@...nel.org>,
        "John Fastabend" <john.fastabend@...il.com>,
        "kpsingh@...omium.org" <kpsingh@...omium.org>
Subject: Re: [PATCH v2 bpf-next 1/2] bpf: introduce BPF_F_PRESERVE_ELEMS for
 perf event array



> On Sep 30, 2020, at 7:49 AM, Daniel Borkmann <daniel@...earbox.net> wrote:
> 
> On 9/29/20 11:56 PM, Song Liu wrote:
> [...]
>>  +static void bpf_fd_array_map_clear(struct bpf_map *map);
>> +
>> +static void perf_event_fd_array_map_free(struct bpf_map *map)
>> +{
>> +	if (map->map_flags & BPF_F_PRESERVE_ELEMS)
>> +		bpf_fd_array_map_clear(map);
>> +	fd_array_map_free(map);
>> +}
> 
> Not quite sure why you place that here and added the fwd declaration? If you
> place perf_event_fd_array_map_free() near perf_event_array_map_ops, then you
> also don't need the additional bpf_fd_array_map_clear declaration.

Yeah.. I misread the line number...

Fixing it in v3.

Thanks,
Song