netdev - Re: [PATCH net 2/2] mptcp: Handle incoming 32-bit DATA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200929.181408.534589469741619213.davem@davemloft.net>
Date:   Tue, 29 Sep 2020 18:14:08 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     mathew.j.martineau@...ux.intel.com
Cc:     netdev@...r.kernel.org, mptcp@...ts.01.org, pabeni@...hat.com
Subject: Re: [PATCH net 2/2] mptcp: Handle incoming 32-bit DATA_FIN values

From: Mat Martineau <mathew.j.martineau@...ux.intel.com>
Date: Tue, 29 Sep 2020 15:08:20 -0700

> The peer may send a DATA_FIN mapping with either a 32-bit or 64-bit
> sequence number. When a 32-bit sequence number is received for the
> DATA_FIN, it must be expanded to 64 bits before comparing it to the
> last acked sequence number. This expansion was missing.
> 
> Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/93
> Fixes: 3721b9b64676 (mptcp: Track received DATA_FIN sequence number and add related helpers)
> Signed-off-by: Mat Martineau <mathew.j.martineau@...ux.intel.com>

The commit header text in a Fixes: tag should be inside of double quotes
as well as parenthesis, like ("this")

I fixed this up while applying this series, but please get it correct
next time.