netdev - Re: RTL8402 stops working after hibernate/resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200930201053.02a3b835@ezekiel.suse.cz>
Date:   Wed, 30 Sep 2020 20:10:53 +0200
From:   Petr Tesarik <ptesarik@...e.cz>
To:     Heiner Kallweit <hkallweit1@...il.com>
Cc:     Hans de Goede <hdegoede@...hat.com>,
        Realtek linux nic maintainers <nic_swsd@...ltek.com>,
        netdev@...r.kernel.org, linux-clk@...r.kernel.org
Subject: Re: RTL8402 stops working after hibernate/resume

On Wed, 30 Sep 2020 17:47:15 +0200
Heiner Kallweit <hkallweit1@...il.com> wrote:

>[...]
> Petr,
> in the following I send two patches. First one is supposed to fix the freeze.
> It also fixes another issue that existed before my ether_clk change:
> ether_clk was disabled on suspend even if WoL is enabled. And the network
> chip most likely needs the clock to check for WoL packets.
> Please let me know whether it fixes the freeze, then I'll add your Tested-by.
> 
> Second patch is a re-send of the one I sent before, it should fix
> the rx issues after resume from suspend for you.
> 
>[...]
> 
> diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realtek/r8169_main.c
> index 9e4e6a883..4fb49fd0d 100644
> --- a/drivers/net/ethernet/realtek/r8169_main.c
> +++ b/drivers/net/ethernet/realtek/r8169_main.c
> @@ -4837,6 +4837,10 @@ static int rtl8169_resume(struct device *device)
>  
>  	rtl_rar_set(tp, tp->dev->dev_addr);
>  
> +	/* Reportedly at least Asus X453MA corrupts packets otherwise */

Just a nitpick: The incoming packets are not corrupted, they are truncated:

+	/* Reportedly at least Asus X453MA truncates packets otherwise */

Other than that, like I have already written in another part of the thread:

Tested-by: Petr Tesarik <ptesarik@...e.com>

> +	if (tp->mac_version == RTL_GIGA_MAC_VER_37)
> +		rtl_init_rxcfg(tp);
> +
>  	if (tp->TxDescArray)
>  		rtl8169_up(tp);
>  
> -- 
> 2.28.0
> 

Content of type "application/pgp-signature" skipped