netdev - Re: [PATCH net-next v2 4/4] dpaa2-eth: add support for devlink parser error drop traps

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200930194407.GA1850258@shredder>
Date:   Wed, 30 Sep 2020 22:44:07 +0300
From:   Ido Schimmel <idosch@...sch.org>
To:     Ioana Ciornei <ioana.ciornei@....com>
Cc:     davem@...emloft.net, kuba@...nel.org, netdev@...r.kernel.org,
        jiri@...dia.com, idosch@...dia.com
Subject: Re: [PATCH net-next v2 4/4] dpaa2-eth: add support for devlink
 parser error drop traps

On Wed, Sep 30, 2020 at 10:16:45PM +0300, Ioana Ciornei wrote:
> +static int dpaa2_eth_dl_trap_action_set(struct devlink *devlink,
> +					const struct devlink_trap *trap,
> +					enum devlink_trap_action action,
> +					struct netlink_ext_ack *extack)
> +{
> +	/* No support for changing the action of an independent packet trap,
> +	 * only per trap group - parser error drops
> +	 */
> +	return -EOPNOTSUPP;

Please also add an error message via extack

> +}