netdev - Re: [PATCH net-next v3 4/4] gve: Add support for raw addressing in the tx path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200930142427.44cf05b3@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Wed, 30 Sep 2020 14:24:27 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     David Awogbemila <awogbemila@...gle.com>
Cc:     netdev@...r.kernel.org, Catherine Sullivan <csully@...gle.com>,
        Yangchun Fu <yangchun@...gle.com>
Subject: Re: [PATCH net-next v3 4/4] gve: Add support for raw addressing in
 the tx path

On Wed, 30 Sep 2020 09:09:57 -0700 David Awogbemila wrote:
> > > +             len -= hlen;
> > > +             addr += hlen;
> > > +             seg_desc = &tx->desc[(tx->req + 1) & tx->mask];
> > > +             seg_idx_bias = 2;
> > > +             gve_tx_fill_seg_desc(seg_desc, skb, is_gso, len, addr);
> > > +     } else {
> > > +             seg_idx_bias = 1;
> > > +             gve_tx_fill_pkt_desc(pkt_desc, skb, is_gso, l4_hdr_offset,
> > > +                                  1 + payload_nfrags, hlen, addr);  
> >
> > and this look identical. You can probably move it before the if.  
> 
> Thanks, I need to make sure I understand: you're referring to the call
> to gve_tx_fill_pkt_desc? if so, the calls look the same but
> payload_nfrags is different in the if and else cases, perhaps I could
> move it after the else? but I'm not sure if that helps.

Fair, you can leave it as is.