netdev - Re: [PATCH net-next 1/2] ionic: stop watchdog timer earlier on remove

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200929171500.0fab7f33@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Tue, 29 Sep 2020 17:15:00 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Shannon Nelson <snelson@...sando.io>
Cc:     netdev@...r.kernel.org, davem@...emloft.net
Subject: Re: [PATCH net-next 1/2] ionic: stop watchdog timer earlier on
 remove

On Tue, 29 Sep 2020 15:19:55 -0700 Shannon Nelson wrote:
> We need to be better at making sure we don't have a link check
> watchdog go off while we're shutting things down, so let's stop
> the timer as soon as we start the remove.
> 
> Meanwhile, since that was the only thing in
> ionic_dev_teardown(), simplify and remove that function.
> 
> Signed-off-by: Shannon Nelson <snelson@...sando.io>

The asymmetry of when the watchdog is started and stopped is a little
strange. Won't there be a similar problem now with the watchdog
starting too early?