netdev - Re: [PATCH v3 net-next 15/15] net: dsa: tag_rtl4_a: use the generic flow dissector procedure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 30 Sep 2020 10:36:31 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Vladimir Oltean <vladimir.oltean@....com>
Cc:     netdev <netdev@...r.kernel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Andrew Lunn <andrew@...n.ch>,
        Florian Fainelli <f.fainelli@...il.com>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Jakub Kicinski <kuba@...nel.org>,
        DENG Qingfang <dqfext@...il.com>,
        Mauri Sandberg <sandberg@...lfence.com>
Subject: Re: [PATCH v3 net-next 15/15] net: dsa: tag_rtl4_a: use the generic
 flow dissector procedure

On Sat, Sep 26, 2020 at 9:33 PM Vladimir Oltean <vladimir.oltean@....com> wrote:

> Remove the .flow_dissect procedure, so the flow dissector will call the
> generic variant which works for this tagging protocol.
>
> Cc: Linus Walleij <linus.walleij@...aro.org>
> Cc: DENG Qingfang <dqfext@...il.com>
> Cc: Mauri Sandberg <sandberg@...lfence.com>
> Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>
> ---
> Changes in v3:
> Remove the .flow_dissect callback altogether.
> Actually copy the people from cc to the patch.

That's a neat refactoring!
Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

Yours,
Linus Walleij