netdev - Re: [RFC net-next 3/9] genetlink: add small version of ops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a8075d1426695435d821331db03765ee8f38d5fa.camel@sipsolutions.net>
Date:   Thu, 01 Oct 2020 09:40:35 +0200
From:   Johannes Berg <johannes@...solutions.net>
To:     Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org
Cc:     andrew@...n.ch, jiri@...nulli.us, mkubecek@...e.cz,
        dsahern@...nel.org, pablo@...filter.org
Subject: Re: [RFC net-next 3/9] genetlink: add small version of ops

On Wed, 2020-09-30 at 17:05 -0700, Jakub Kicinski wrote:
> We want to add maxattr and policy back to genl_ops, to enable
> dumping per command policy to user space. This, however, would
> cause bloat for all the families with global policies. Introduce
> smaller version of ops (half the size of genl_ops). Translate
> these smaller ops into a full blown struct before use in the
> core.

LGTM. That part about the WARN_ON was even easier than I thought :)

Reviewed-by: Johannes Berg <johannes@...solutions.net>

johannes