netdev - Re: [PATCH net-next] Revert "vxlan: move encapsulation warning"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <577402571.31284.1601571084230@webmail.appsuite.proximus.be>
Date:   Thu, 1 Oct 2020 18:51:24 +0200 (CEST)
From:   Fabian Frederick <fabf@...net.be>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] Revert "vxlan: move encapsulation warning"


> On 30/09/2020 18:29 Jakub Kicinski <kuba@...nel.org> wrote:
> 
>  
> On Wed, 30 Sep 2020 18:20:05 +0200 (CEST) Fabian Frederick wrote:
> > Thanks a lot for explanations Jakub. udp_tunnel_nic.sh is a nice
> > tool. Maybe it could also be used for remcsum testing ? I'd like to
> > check net-next commit 2ae2904b5bac "vxlan: don't collect metadata if
> > remote checksum is wrong" to make sure it has no impact as I had no
> > ACK. Problem is ip encap-remcsum requires 'remote' specification not
> > compatible with 'group' and only featuring in 'new_geneve' function
> > in your script.
> > 
> > If both vxlan_parse_gbp_hdr() and vxlan_remcsum() require metadata
> > recovery, I can reverse that patch and add some comment in vxlan_rcv()
> 
> I think it's better if you create a separate script for that.
> 
> udp_tunnel_nic is supposed to be testing the NIC driver interface.

Looking at 'man ip link add', the only option to enable metadata seems 'external' which can't be declared with 'remote'

Result when trying to create vlxan:

vxlan: both 'external' and vni cannot be specified

Is there another way to check both VXLAN_F_COLLECT_METADATA and VXLAN_F_REMCSUM_RX ?

I just noticed that before commit f14ecebb3a4e 
("vxlan: clean up extension handling on rx")

checksum was tested before metadata collecting in vxlan_udp_encap_recv() so there should be no problem restoring initial behavior.

Best regards,
Fabian